[
https://issues.apache.org/jira/browse/ARTEMIS-2662?focusedWorklogId=404579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404579
]
ASF GitHub Bot logged work on ARTEMIS-2662:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 09:49
Start Date: 17/Mar/20 09:49
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #3021:
ARTEMIS-2662 Using previously stored encodeSize on page record offset
URL: https://github.com/apache/activemq-artemis/pull/3021#discussion_r393557182
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagedMessageImpl.java
##########
@@ -59,8 +61,19 @@ public PagedMessageImpl(final Message message, final long[]
queueIDs) {
this.message = message;
}
- public PagedMessageImpl(StorageManager storageManager) {
+ public PagedMessageImpl(int storedSize, StorageManager storageManager) {
this.storageManager = storageManager;
+ this.storedSize = storedSize;
+ }
+
+
+ @Override
+ public int getStoredSize() {
+ if (storedSize <= 0) {
Review comment:
I am not sure it's safe to do that in case the encodeSize changed between
the contruction and when getStoredSize is used.
We can change this If you're sure it's safe. I wasn't bold enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404579)
Time Spent: 1h 40m (was: 1.5h)
> Page is broken for AMQP if readWholePage=true
> ---------------------------------------------
>
> Key: ARTEMIS-2662
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2662
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.10.0, 2.10.1
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
