[
https://issues.apache.org/jira/browse/ARTEMIS-2662?focusedWorklogId=404563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404563
]
ASF GitHub Bot logged work on ARTEMIS-2662:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 09:29
Start Date: 17/Mar/20 09:29
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3021: ARTEMIS-2662
Using previously stored encodeSize on page record offset
URL: https://github.com/apache/activemq-artemis/pull/3021#discussion_r393542458
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
##########
@@ -1357,7 +1357,7 @@ private PagedReference moveNext() {
break;
}
- int nextFileOffset = message.getPosition().getFileOffset() ==
-1 ? -1 : message.getPosition().getFileOffset() +
message.getPagedMessage().getEncodeSize() + Page.SIZE_RECORD;
+ int nextFileOffset = message.getPosition().getFileOffset() ==
-1 ? -1 : message.getPosition().getFileOffset() +
message.getPagedMessage().getStoredSize() + Page.SIZE_RECORD;
Review comment:
I would encapsulate this computation as part of `PagedMessage` or
`PagePosition` , possibly adding a test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404563)
Time Spent: 50m (was: 40m)
> Page is broken for AMQP if readWholePage=true
> ---------------------------------------------
>
> Key: ARTEMIS-2662
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2662
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.10.0, 2.10.1
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
