[
https://issues.apache.org/jira/browse/ARTEMIS-2662?focusedWorklogId=404585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404585
]
ASF GitHub Bot logged work on ARTEMIS-2662:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 09:59
Start Date: 17/Mar/20 09:59
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #3021:
ARTEMIS-2662 Using previously stored encodeSize on page record offset
URL: https://github.com/apache/activemq-artemis/pull/3021#discussion_r393562799
##########
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageReaderTest.java
##########
@@ -58,7 +58,7 @@ public void testPageReadMessage() throws Exception {
PagePosition pagePosition = new PagePositionImpl(10, i);
pagedMessage = pageReader.getMessage(pagePosition);
} else {
- int nextFileOffset = pagedMessage == null ? -1 : offsets[i - 1] +
pagedMessage.getEncodeSize() + Page.SIZE_RECORD;
+ int nextFileOffset = pagedMessage == null ? -1 : offsets[i - 1] +
pagedMessage.getStoredSize() + Page.SIZE_RECORD;
Review comment:
It's not that simple to move this test. it uses a lot of package private
methods.. moving would need to make them public or a bigger refactoring.
I had a version where I did this at some point. I would go for the simpler
version now in case we ever need to cherry-pick to a point release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404585)
Time Spent: 2h (was: 1h 50m)
> Page is broken for AMQP if readWholePage=true
> ---------------------------------------------
>
> Key: ARTEMIS-2662
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2662
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.10.0, 2.10.1
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
