[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870343
]
ASF GitHub Bot logged work on ARTEMIS-4353:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/23 14:45
Start Date: 11/Jul/23 14:45
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1259848820
##########
artemis-quorum-ri/pom.xml:
##########
@@ -43,6 +47,12 @@
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
+ <scope>test</scope>
Review Comment:
Also not sure about this one changing to test. The main purpose of this
module is currently to use ZK. That it does it via the curator stuff doesnt
really mean this is a test-only dep, whilst listing it like this really makes
it seem like it is...however anything using this module will still get ZK since
it isnt really. Maven doesnt have a way of saying "runtime + test" which is
what this really is. I think I'd leave it at compile for clarity.
Issue Time Tracking
-------------------
Worklog Id: (was: 870343)
Time Spent: 1h (was: 50m)
> Clean up Maven dependencies
> ---------------------------
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
