[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870665
]
ASF GitHub Bot logged work on ARTEMIS-4353:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/23 19:17
Start Date: 12/Jul/23 19:17
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1261628995
##########
artemis-quorum-ri/src/test/java/org/apache/activemq/artemis/quorum/DistributedLockTest.java:
##########
@@ -222,7 +219,7 @@ public void timedTryLockFailAfterTimeout() throws
ExecutionException, Interrupte
final long timeoutSec = 1;
Assert.assertFalse(manager.getDistributedLock("a").tryLock(timeoutSec,
TimeUnit.SECONDS));
final long elapsed = TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() -
start);
- assertThat(elapsed, greaterThanOrEqualTo(timeoutSec));
+ Assert.assertTrue(elapsed >= timeoutSec);
Review Comment:
I agree that Hamcrest provides better messages when assertions fail,
although there are huge number of vague uses of `assertTrue` throughout the
code-base. I've added messages where I thought it made sense or changed
`assertTrue` to `assertEquals` to get an automated message which is more useful.
Issue Time Tracking
-------------------
Worklog Id: (was: 870665)
Time Spent: 2h (was: 1h 50m)
> Clean up Maven dependencies
> ---------------------------
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
