[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870770
]
ASF GitHub Bot logged work on ARTEMIS-4353:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/23 10:41
Start Date: 13/Jul/23 10:41
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1262375357
##########
artemis-quorum-ri/src/test/java/org/apache/activemq/artemis/quorum/DistributedLockTest.java:
##########
@@ -222,7 +219,7 @@ public void timedTryLockFailAfterTimeout() throws
ExecutionException, Interrupte
final long timeoutSec = 1;
Assert.assertFalse(manager.getDistributedLock("a").tryLock(timeoutSec,
TimeUnit.SECONDS));
final long elapsed = TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() -
start);
- assertThat(elapsed, greaterThanOrEqualTo(timeoutSec));
+ Assert.assertTrue(elapsed >= timeoutSec);
Review Comment:
Yeah, I wasnt saying you needed to do them all (though it is certainly nicer
to so you dont need to open the code to read the assertion when a test run
fails).
Its more the things where if it failed, you would only know partial
detail...e.g if an assert was checking for a specific class and failed due to
an unexpected class (but which one was it actually?), or a value wasnt between
expected X and Y (but what was it?), etc. The ones where the assertion failure
doesnt implicitly give you enough context to know what did happen, even though
that might greatly help you figure out why what you expected didnt happen.
Issue Time Tracking
-------------------
Worklog Id: (was: 870770)
Time Spent: 2h 10m (was: 2h)
> Clean up Maven dependencies
> ---------------------------
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
