[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870517
]
ASF GitHub Bot logged work on ARTEMIS-4353:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/23 10:19
Start Date: 12/Jul/23 10:19
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1260955912
##########
artemis-junit/artemis-junit-5/pom.xml:
##########
@@ -57,12 +57,7 @@
</dependency>
<dependency>
<groupId>org.apache.activemq</groupId>
- <artifactId>artemis-jms-server</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-jms-client</artifactId>
Review Comment:
I was 'ok' with this removal since the junit 5 stuff is actually 'core
centric' (which again, I dont actually think makes any sense, since we would
recommend the JMS client to most, and most I've seen using this want it to test
with the JMS client, so they typically shouldn't be using the core API directly
for anything).
Thats unlike the original junit 4 aimed stuff though, which has some very
JMS-specific bits as well, that do use the JMS client, so I dont think it
should be removed from the junit 4 stuff at this point since that has always
supplied the JMS client, and some will expect it to.
I have however been forgetting about junit-commons module also existing,
which is perhaps still supplying the jms client to _both_ the junit 4 and 5
modules (the latter should arguably be excluding it if so) ?
Issue Time Tracking
-------------------
Worklog Id: (was: 870517)
Time Spent: 1.5h (was: 1h 20m)
> Clean up Maven dependencies
> ---------------------------
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
