[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870647
]
ASF GitHub Bot logged work on ARTEMIS-4353:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/23 16:42
Start Date: 12/Jul/23 16:42
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1261447705
##########
artemis-junit/artemis-junit-5/pom.xml:
##########
@@ -57,12 +57,7 @@
</dependency>
<dependency>
<groupId>org.apache.activemq</groupId>
- <artifactId>artemis-jms-server</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-jms-client</artifactId>
Review Comment:
I see your point about the module providing the client to the depender to
make testing easier. I think that's fair.
Issue Time Tracking
-------------------
Worklog Id: (was: 870647)
Time Spent: 1h 50m (was: 1h 40m)
> Clean up Maven dependencies
> ---------------------------
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)