[
https://issues.apache.org/jira/browse/ARROW-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253974#comment-16253974
]
ASF GitHub Bot commented on ARROW-590:
--------------------------------------
wesm commented on a change in pull request #987: ARROW-590: Add integration
tests for Union types
URL: https://github.com/apache/arrow/pull/987#discussion_r151224151
##########
File path: java/vector/src/main/codegen/templates/UnionVector.java
##########
@@ -74,13 +89,39 @@
private final CallBack callBack;
private final List<BufferBacked> innerVectors;
- public UnionVector(String name, BufferAllocator allocator, CallBack
callBack) {
+ private int[] typeIds;
Review comment:
I believe this is about the format specification provides for fixed type
code mapping, e.g.
```
type 0 -> 5
type 1 -> 10
type 2 -> 15
```
I think the original motivation was to be able to utilized fixed type codes
for certain data types
In C++ you can see the `arrow::UnionType` constructor takes a vector of type
codes https://github.com/apache/arrow/blob/master/cpp/src/arrow/type.h#L531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add integration tests for Union types
> -------------------------------------
>
> Key: ARROW-590
> URL: https://issues.apache.org/jira/browse/ARROW-590
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Java - Vectors
> Reporter: Wes McKinney
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
