[
https://issues.apache.org/jira/browse/ARROW-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254051#comment-16254051
]
ASF GitHub Bot commented on ARROW-590:
--------------------------------------
icexelloss commented on a change in pull request #987: ARROW-590: Add
integration tests for Union types
URL: https://github.com/apache/arrow/pull/987#discussion_r151233251
##########
File path: java/vector/src/main/codegen/templates/UnionVector.java
##########
@@ -74,13 +89,39 @@
private final CallBack callBack;
private final List<BufferBacked> innerVectors;
- public UnionVector(String name, BufferAllocator allocator, CallBack
callBack) {
+ private int[] typeIds;
Review comment:
The second. I believe the java vector assumes a certain possible subset of
the cases -
specifically the java vector assumes the typeIds are the ordinal value of
the enum MinorType. If the java class is consuming an union vector that happens
to using ordinal value of enum MinorType for typeIds (for instance, a union
vector produced by java) then it would work. Otherwise it would not work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add integration tests for Union types
> -------------------------------------
>
> Key: ARROW-590
> URL: https://issues.apache.org/jira/browse/ARROW-590
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Java - Vectors
> Reporter: Wes McKinney
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
