[
https://issues.apache.org/jira/browse/ARROW-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254028#comment-16254028
]
ASF GitHub Bot commented on ARROW-590:
--------------------------------------
icexelloss commented on a change in pull request #987: ARROW-590: Add
integration tests for Union types
URL: https://github.com/apache/arrow/pull/987#discussion_r151231251
##########
File path: java/vector/src/main/codegen/templates/UnionVector.java
##########
@@ -269,12 +373,14 @@ public void clear() {
public Field getField() {
List<org.apache.arrow.vector.types.pojo.Field> childFields = new
ArrayList<>();
List<FieldVector> children = internalMap.getChildren();
- int[] typeIds = new int[children.size()];
for (ValueVector v : children) {
- typeIds[childFields.size()] = v.getMinorType().ordinal();
Review comment:
@jacques-n This is the code I am referring to that assumes type id is the
value of the enum MinorType rather than typeIds in the schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add integration tests for Union types
> -------------------------------------
>
> Key: ARROW-590
> URL: https://issues.apache.org/jira/browse/ARROW-590
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Java - Vectors
> Reporter: Wes McKinney
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
