[
https://issues.apache.org/jira/browse/ARROW-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254039#comment-16254039
]
ASF GitHub Bot commented on ARROW-590:
--------------------------------------
jacques-n commented on a change in pull request #987: ARROW-590: Add
integration tests for Union types
URL: https://github.com/apache/arrow/pull/987#discussion_r151231973
##########
File path: java/vector/src/main/codegen/templates/UnionVector.java
##########
@@ -74,13 +89,39 @@
private final CallBack callBack;
private final List<BufferBacked> innerVectors;
- public UnionVector(String name, BufferAllocator allocator, CallBack
callBack) {
+ private int[] typeIds;
Review comment:
I haven't spent the time against understanding this yet but to clarify:
do you believe:
- the java vector has an invalid representation?
or
- the java vector assumes a certain possible subset of cases?
The fact that the java user layer uses a specific type mapping (rather than
supporting every type mapping) isn't in itself a violation of the spec. Or am I
missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add integration tests for Union types
> -------------------------------------
>
> Key: ARROW-590
> URL: https://issues.apache.org/jira/browse/ARROW-590
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Java - Vectors
> Reporter: Wes McKinney
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
