[
https://issues.apache.org/jira/browse/ARROW-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254017#comment-16254017
]
ASF GitHub Bot commented on ARROW-590:
--------------------------------------
icexelloss commented on a change in pull request #987: ARROW-590: Add
integration tests for Union types
URL: https://github.com/apache/arrow/pull/987#discussion_r151229258
##########
File path: java/vector/src/main/codegen/templates/UnionVector.java
##########
@@ -74,13 +89,39 @@
private final CallBack callBack;
private final List<BufferBacked> innerVectors;
- public UnionVector(String name, BufferAllocator allocator, CallBack
callBack) {
+ private int[] typeIds;
Review comment:
Wes is correct. Before the change the Java class assumes the type id to be
the int value of the enum MinorType, which breaks interoperability with C++.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add integration tests for Union types
> -------------------------------------
>
> Key: ARROW-590
> URL: https://issues.apache.org/jira/browse/ARROW-590
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Java - Vectors
> Reporter: Wes McKinney
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
