zcsizmadia commented on a change in pull request #981:
URL: https://github.com/apache/avro/pull/981#discussion_r523851230
##########
File path: lang/csharp/src/apache/main/Generic/GenericRecord.cs
##########
@@ -239,7 +239,7 @@ public override string ToString()
sb.Append(contents[field.Pos]);
sb.Append(", ");
}
- sb.Append("}");
+ sb.Append('}');
Review comment:
The latest msbuild 16.8 has many new warnings (which are mostly
seful/valid). The compiler was complaining that StringBuilder.Append(char)
should be used if the string arg is a single character. It is more efficient I
guess, sinve only a char has to be passed on the stack to the function. There
were many Append(string with 1 char) calls, and all of them caused a warning->
error since all warnings are treated as errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
