zcsizmadia commented on a change in pull request #981:
URL: https://github.com/apache/avro/pull/981#discussion_r523851771
##########
File path: lang/csharp/src/apache/main/Schema/SchemaName.cs
##########
@@ -64,7 +64,7 @@ public SchemaName(String name, String space, String encspace)
this.EncSpace = encspace; // need to save enclosing
namespace for anonymous types, so named types within the anonymous type can be
resolved
}
#pragma warning disable CA1307 // Specify StringComparison
- else if (name.IndexOf('.') == -1)
+ else if (!name.Contains("."))
Review comment:
This was another msbuild 16.8 warning/error. Use Contains instead of
cmparing IndexOf() to -1, to make the code "more readable". It is kinda cool
how many new warnings they introduced with 16.8 msbuild/net 5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
