zcsizmadia commented on a change in pull request #981:
URL: https://github.com/apache/avro/pull/981#discussion_r523860118
##########
File path: lang/csharp/src/apache/test/Avro.test.csproj
##########
@@ -17,8 +17,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFrameworks
Condition="'$(OS)'!='Windows_NT'">netcoreapp3.1</TargetFrameworks>
- <TargetFrameworks
Condition="'$(OS)'=='Windows_NT'">net461;netcoreapp3.1</TargetFrameworks>
+ <TargetFrameworks
Condition="'$(OS)'!='Windows_NT'">net5.0</TargetFrameworks>
+ <TargetFrameworks
Condition="'$(OS)'=='Windows_NT'">net461;net5.0</TargetFrameworks>
Review comment:
> I compiled the following table of updated dependencies in this PR. We
should probably list these out in the commit message and/or Jira issue.
>
> Package Old New
> Microsoft.CodeAnalysis.FxCopAnalyzers 2.9.8 3.3.1
> Newtonsoft.Json 10.0.3 12.0.3
> System.CodeDom 4.4.0 5.0.0
> System.Reflection.Emit.ILGeneration 4.3.0 4.7.0
> System.Reflection.Emit.Lightweight 4.3.0 4.7.0
> Microsoft.Build.Framework 15.6.82 16.8.0
> Microsoft.Build.Utilities.Core 15.6.82 16.8.0
> nunit3testadapter 3.16.1 3.17.0
> NUnit.ConsoleRunner 3.10.0 3.11.1
> Microsoft.NET.Test.Sdk 16.4.0 16.8.0
Usually what I do in .net projects, I add a Versions.prtops file int h eroot
and all csproj files include it, just like the Common.props. This file only
have PACKAGENAMEVersion defines in them. e.g. "NewtonsoftJsonVersion" =
"12.0.3". Every csproj in the source tree will use only PACKAGENAMEVersion
defines in the PackageReference, so the version "upgrade" is clean and simple,
only change in one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
