zcsizmadia commented on a change in pull request #981:
URL: https://github.com/apache/avro/pull/981#discussion_r523851474



##########
File path: lang/csharp/src/apache/test/Reflect/TestFromAvroProject.cs
##########
@@ -189,7 +189,8 @@ public Z SerializeDeserialize(Z z)
             catch (Exception ex)
             {
                 Console.WriteLine(ex.ToString());
-                throw ex;
+                // Note: Re-throwing caught exception changes stack information
+                throw;

Review comment:
       Will do :) I ran into probl;ems when I was rethrowing with ex, and my 
call stack was very misleading ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to