zcsizmadia commented on a change in pull request #981:
URL: https://github.com/apache/avro/pull/981#discussion_r523862229
##########
File path: lang/csharp/src/apache/test/Avro.test.csproj
##########
@@ -17,8 +17,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFrameworks
Condition="'$(OS)'!='Windows_NT'">netcoreapp3.1</TargetFrameworks>
- <TargetFrameworks
Condition="'$(OS)'=='Windows_NT'">net461;netcoreapp3.1</TargetFrameworks>
+ <TargetFrameworks
Condition="'$(OS)'!='Windows_NT'">net5.0</TargetFrameworks>
+ <TargetFrameworks
Condition="'$(OS)'=='Windows_NT'">net461;net5.0</TargetFrameworks>
Review comment:
> It may be good for us to continue testing against .NET Core 3.1, just
in case there was some compatibility issue between the two.
Good catch. Now thinking about this. I think it should be netcoreapp2.1
added to it (or 2.1 and 3.1). So here is my logic, let me know if I miss or
misunderstand something.
Avro.main is compiled for netstandard2.0, netstandard2.1 and netcoreapp2.1.
Netstandard2.1 and netcoreapp2.1 (which is btw is very much like
netstandard2.1, without having netstandard2.1 support). There is no other
framework in Avro.main, since MS recommends to add netcoreapp or other
frameweorks only if the library is really compiled with some specific framweork
feature/API (using ifdef). SO we are good there.
When Avro.test is tested, all frameworks will be tested in the
TargetFramworks list (if no --framework is specified).
netf461 will use netstandard2.0 so netstandard2.0 version of Avro.main is
tested.
netcoreapp2.1 fw of Avro.test would be linked against the netcoreapp2.1
version of Avro.main since that specific fw exists in the nuget package and
Avro.main.
netcoreapp3.1 or net5.0 will link against netstandard2.1, since both of them
support it, and msbuild will be pick the most appropiate and (best) choice of
matching fw.
Honsetly, since the test is very fast, I would add all supported frtameworks
to Avro.test. net461,netcoreapp2.1, netcoreepp3.1 and net5.0 (it might test
netstandard2.1 2x.).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
