[ 
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=617482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617482
 ]

ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/21 09:07
            Start Date: 01/Jul/21 09:07
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r662117312



##########
File path: 
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -486,6 +504,11 @@ default InputT createInput(Pipeline p, Map<String, 
PCollection<?>> inputs) {
         .build();
   }
 
+  protected Pipeline createPipeline() {
+    pipelineOptions.setRunner(NoOpRunner.class);

Review comment:
       How about just adding both "beam-sdks-java-io-expansion-service" and 
beam-runners-direct-java" to the classpath when starting up the expansion 
service ? No need to update dependencies of Beam. Following seems to work for 
me.
   
   export 
CLASSPATH=beam-sdks-java-io-expansion-service-2.32.0-SNAPSHOT.jar:beam-runners-direct-java-2.32.0-SNAPSHOT.jar
   java org.apache.beam.sdk.expansion.service.ExpansionService 12345
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 617482)
    Time Spent: 1h 40m  (was: 1.5h)

> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
>                 Key: BEAM-12538
>                 URL: https://issues.apache.org/jira/browse/BEAM-12538
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language
>    Affects Versions: 2.31.0
>            Reporter: Jan Lukavský
>            Assignee: Jan Lukavský
>            Priority: P2
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port 
> number). It is needed to allow it to accept at least 
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from 
> {{PortablePipelineOptions}} to be able to specify environment of the expanded 
> transform.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to