[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=617747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617747
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 18:52
Start Date: 01/Jul/21 18:52
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r662522137
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -391,17 +410,19 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
request.getTransform().getSpec().getUrn());
LOG.debug("Full transform: {}", request.getTransform());
Set<String> existingTransformIds =
request.getComponents().getTransformsMap().keySet();
- Pipeline pipeline = Pipeline.create();
- ExperimentalOptions.addExperiment(
- pipeline.getOptions().as(ExperimentalOptions.class), "beam_fn_api");
- // TODO(BEAM-10670): Remove this when we address performance issue.
- ExperimentalOptions.addExperiment(
- pipeline.getOptions().as(ExperimentalOptions.class), "use_sdf_read");
+ Pipeline pipeline = createPipeline();
+ if (!ExperimentalOptions.hasExperiment(pipelineOptions,
"use_deprecated_read")) {
Review comment:
Not as part of this PR, but I believe there are tests for that. We need
it so that we don't override `use_deprecated_read` with `use_sdf_read`
(opt-out, then opt-in).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617747)
Time Spent: 2.5h (was: 2h 20m)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
