[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=617802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617802
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 20:06
Start Date: 01/Jul/21 20:06
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #15082:
URL: https://github.com/apache/beam/pull/15082#issuecomment-872516504
> > Why would annotations be safer?
>
> That might be only opinion-based. But creating new
`ExternalServiceOptions` means you have two places to add an option when you
want it to be respected by both runners and external services - you will not
add an option to ExternalServiceOptions _only_. That is only a projection, not
a complete domain. That is why I think, that selection is better done with
annotations.
Creating ExternalServiceOptions doesn't mean we need to define new options.
For example, we could refactor environment-related options into a new
PortableEnvironmentOptions class, and then make both PortablePipelineOptions
and ExternalServiceOptions extend PortableEnvironmentOptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617802)
Time Spent: 3h 20m (was: 3h 10m)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
