[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=617486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617486
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 09:11
Start Date: 01/Jul/21 09:11
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r662120548
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -486,6 +504,11 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
.build();
}
+ protected Pipeline createPipeline() {
+ pipelineOptions.setRunner(NoOpRunner.class);
Review comment:
The problem is that `:sdks:java:expansion-service` would (in fact)
depend on :runners:direct-java`. It would require this at least for
`testRuntimeOnly`, but actually all uses of this module would need to add that
(or any other runner and specify --runner, but that will get ignored). I think
that the biggest problem is that runner is marked `@Validation.Required`,
athough it is not required (apparently, expansion service works without
runner). That is the root issue and everything else seems like a (smaller or
bigger) hack. Implementing a `NoOpRunner` seems like the smallest issue, as
that does not leak or break users anyhow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617486)
Time Spent: 1h 50m (was: 1h 40m)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
