[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=617808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617808
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 20:12
Start Date: 01/Jul/21 20:12
Worklog Time Spent: 10m
Work Description: je-ik edited a comment on pull request #15082:
URL: https://github.com/apache/beam/pull/15082#issuecomment-872519819
> Creating ExternalServiceOptions doesn't mean we need to define new
options. For example, we could refactor environment-related options into a new
PortableEnvironmentOptions class, and then make both PortablePipelineOptions
and ExternalServiceOptions extend PortableEnvironmentOptions.
That makes sense, but that applies to current state only, right? When a new
option is added, would the author of the change know exactly where to put the
option? The ExternalServiceOptions 'look' like being applied to external
service only. That is not the case. And we would have to move complete
ExperimentalOptions to ExternalServiceOptions, which seems problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617808)
Time Spent: 3h 40m (was: 3.5h)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
