[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=617878&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617878
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 22:12
Start Date: 01/Jul/21 22:12
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #15082:
URL: https://github.com/apache/beam/pull/15082#issuecomment-872581895
> > I don't see how this would be different with annotations. We don't need
to move any options, just capture a subset. (To be clear, I was imagining
something like `ExpansionServiceOptions extends PortableEnvironmentOptions,
ExperimentalOptions`.)
>
> Yes, inheritance works the same, if we can easily do that, then it would
be OK in this sense. Still, it would require that all the options
(`PortableEnvironmentOptions`) be respected by `ExpansionServiceOptions`, which
is not the case.
That's why I propose separating out PortableEnvironmentOptions from
PortablePipelineOptions. It'd be like this:
PortableEnvironmentOptions
PortablePipelineOptions extends PortableEnvironmentOptions, ...
ExpansionServiceOptions extends PortableEnvironmentOptions,
ExperimentalOptions
Ideally though we wouldn't need ExperimentalOptions, as we're discussing on
the mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617878)
Time Spent: 4h 10m (was: 4h)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
