[
https://issues.apache.org/jira/browse/BEAM-6751?focusedWorklogId=213273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213273
]
ASF GitHub Bot logged work on BEAM-6751:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/19 17:19
Start Date: 14/Mar/19 17:19
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #7991: [BEAM-6751] Add
KafkaIO EOS support to Flink via @RequiresStableInput
URL: https://github.com/apache/beam/pull/7991#issuecomment-472972869
This is problematic then, as it will slow KafkaIO down a lot on Dataflow.
Maybe we should rollback pr/5787 then until we can do this more
intelligently on Dataflow?
On Wed, Mar 13, 2019 at 3:27 PM Yueyang Qiu <[email protected]>
wrote:
> *@robinyqiu* commented on this pull request.
> ------------------------------
>
> In
>
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java
> <https://github.com/apache/beam/pull/7991#discussion_r265356322>:
>
> > @@ -274,6 +274,7 @@ public void setup() {
>
> // Futures ignored as exceptions will be flushed out in the commitTxn
> @SuppressWarnings("FutureReturnValueIgnored")
> + @RequiresStableInput
>
> @reuvenlax <https://github.com/reuvenlax> FYI, @RequiresStableInput is
> already supported on Dataflow runner (PR: #5787
> <https://github.com/apache/beam/pull/5787>), so I believe it will add an
> extra Reshuffle instead of doing nothing.
>
> In my previous work, I didn't replace the hard-coded Reshuffles with
> @RequiresStableInput, mainly because we are not sure how it will affect
> Spark and Flink runners.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/7991#discussion_r265356322>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AUGE1YgQUqux3HpiUnrspvvg1QK-WXYBks5vWXtIgaJpZM4bfQMy>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 213273)
Time Spent: 7h (was: 6h 50m)
> KafkaIO's EOS mode does not work with FlinkRunner
> -------------------------------------------------
>
> Key: BEAM-6751
> URL: https://issues.apache.org/jira/browse/BEAM-6751
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> KafkaIO has a validation check which whitelists certain runners capable of
> provide exactly-once semantics:
> {noformat}
> if ("org.apache.beam.runners.direct.DirectRunner".equals(runner)
> || runner.startsWith("org.apache.beam.runners.dataflow.")
> || runner.startsWith("org.apache.beam.runners.spark.") {
> ...
> {noformat}
> The Flink supports exactly-once checkpointing but the Flink Runner can't
> utilize it in the way KafkaIO intends it.
> I think we should remove the check in favor of checking for translation of
> {{@RequiresStableInput}}. Changes to KafkaIO might have to be made to support
> EOS efficiently with the Flink Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
