[
https://issues.apache.org/jira/browse/BEAM-6751?focusedWorklogId=213457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213457
]
ASF GitHub Bot logged work on BEAM-6751:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/19 22:38
Start Date: 14/Mar/19 22:38
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #7991: [BEAM-6751] Add
KafkaIO EOS support to Flink via @RequiresStableInput
URL: https://github.com/apache/beam/pull/7991#issuecomment-473092787
BTW this is one of the problems with Reshuffle: it had several different
semantically different uses, and they are sometimes hard to tease apart.
On Thu, Mar 14, 2019 at 3:33 PM Raghu Angadi <[email protected]>
wrote:
> On Thu, Mar 14, 2019 at 3:22 PM reuvenlax <[email protected]>
> wrote:
>
> > But we'll also need to add RequiresStableInput on the FileBasedSink and
> > BigQuery sink, and simply removing reshuffle there isn't quite so simple
> > (in many cases the Reshuffle is also there to parallelize work, not just
> > for stable input). I think we probably should disable the Dataflow code
> and
> > make it more intelligent.
> >
>
> Make sense. Thanks.
>
>
> > On Thu, Mar 14, 2019 at 3:18 PM Raghu Angadi <[email protected]>
> > wrote:
> >
> > > I am not sure I understand. Which Reshuffle are you referring to?
> > >
> > > FYI, the current Dataflow implementation is that a transform T marked
> > with
> > > @RequiresStableInputwill be replaced with (Reshuffle + T). This happens
> > > during pipeline construction time.
> > > Kafka EOS does this now : T1 -> Reshard -> T2 -> Reshuffle -> Sink
> > >
> > > The trailing Reshuffle -> Sink can be replaced with
> '@RequiresStableInput
> > > Sink', so it becomes T1 -> Reshard -> T2 -> Sink with Stable Input.
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/apache/beam/pull/7991#issuecomment-473087179>, or
> > mute
> > > the thread
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AUGE1X9OspnFE6Qbcp6YLKx_CUl9qIRdks5vWsqogaJpZM4bfQMy
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/apache/beam/pull/7991#issuecomment-473088317>, or
> mute
> > the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AAeq-p6QyPntQdreqGYZ6Y4QKUprzt9Uks5vWsuKgaJpZM4bfQMy
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/7991#issuecomment-473091557>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AUGE1Wj6lnOE03c6KWgwUXAY9ttpR1ioks5vWs5UgaJpZM4bfQMy>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 213457)
Time Spent: 8.5h (was: 8h 20m)
> KafkaIO's EOS mode does not work with FlinkRunner
> -------------------------------------------------
>
> Key: BEAM-6751
> URL: https://issues.apache.org/jira/browse/BEAM-6751
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> KafkaIO has a validation check which whitelists certain runners capable of
> provide exactly-once semantics:
> {noformat}
> if ("org.apache.beam.runners.direct.DirectRunner".equals(runner)
> || runner.startsWith("org.apache.beam.runners.dataflow.")
> || runner.startsWith("org.apache.beam.runners.spark.") {
> ...
> {noformat}
> The Flink supports exactly-once checkpointing but the Flink Runner can't
> utilize it in the way KafkaIO intends it.
> I think we should remove the check in favor of checking for translation of
> {{@RequiresStableInput}}. Changes to KafkaIO might have to be made to support
> EOS efficiently with the Flink Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
