[
https://issues.apache.org/jira/browse/BEAM-6751?focusedWorklogId=213444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213444
]
ASF GitHub Bot logged work on BEAM-6751:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/19 22:08
Start Date: 14/Mar/19 22:08
Worklog Time Spent: 10m
Work Description: robinyqiu commented on issue #7991: [BEAM-6751] Add
KafkaIO EOS support to Flink via @RequiresStableInput
URL: https://github.com/apache/beam/pull/7991#issuecomment-473084636
> > @reuvenlax Yes. The current way we implement `@RequiresStableInput` on
Dataflow is not intelligent. I can send a PR to disable the current
implementation and make `@RequiresStableInput` a no-op on Dataflow, in order to
unblock this PR.
>
> How about we keep Dataflow implemenation and remove a reshuffle here? We
can remove Spark support for now until it has support for @RequiresStableInput.
I am not sure I understand. Which `Resuffle` are you referring to?
FYI, the current Dataflow implementation is that a transform T marked with
`@RequiresStableInput`will be replaced with (Reshuffle + T). This happens
during pipeline construction time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 213444)
Time Spent: 7.5h (was: 7h 20m)
> KafkaIO's EOS mode does not work with FlinkRunner
> -------------------------------------------------
>
> Key: BEAM-6751
> URL: https://issues.apache.org/jira/browse/BEAM-6751
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> KafkaIO has a validation check which whitelists certain runners capable of
> provide exactly-once semantics:
> {noformat}
> if ("org.apache.beam.runners.direct.DirectRunner".equals(runner)
> || runner.startsWith("org.apache.beam.runners.dataflow.")
> || runner.startsWith("org.apache.beam.runners.spark.") {
> ...
> {noformat}
> The Flink supports exactly-once checkpointing but the Flink Runner can't
> utilize it in the way KafkaIO intends it.
> I think we should remove the check in favor of checking for translation of
> {{@RequiresStableInput}}. Changes to KafkaIO might have to be made to support
> EOS efficiently with the Flink Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
