[
https://issues.apache.org/jira/browse/BEAM-6674?focusedWorklogId=251955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-251955
]
ASF GitHub Bot logged work on BEAM-6674:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/19 18:28
Start Date: 31/May/19 18:28
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #8725: [BEAM-6674]
Add schema support to JdbcIO read
URL: https://github.com/apache/beam/pull/8725#discussion_r289504158
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -391,6 +403,123 @@ DataSource buildDatasource() {
void setParameters(PreparedStatement preparedStatement) throws Exception;
}
+ /** Implementation of {@link #readRows()}. */
+ @AutoValue
+ @Experimental(Experimental.Kind.SCHEMAS)
+ public abstract static class ReadRows extends PTransform<PBegin,
PCollection<Row>> {
Review comment:
can we share the part that's common with Read? I'm worried that that people
will end up adding features to one codepath and not the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 251955)
Time Spent: 1h 10m (was: 1h)
> The JdbcIO source should produce schemas
> ----------------------------------------
>
> Key: BEAM-6674
> URL: https://issues.apache.org/jira/browse/BEAM-6674
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-jdbc
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
