[
https://issues.apache.org/jira/browse/BEAM-6674?focusedWorklogId=252834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252834
]
ASF GitHub Bot logged work on BEAM-6674:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/19 11:07
Start Date: 02/Jun/19 11:07
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #8725: [BEAM-6674] Add
schema support to JdbcIO read
URL: https://github.com/apache/beam/pull/8725#issuecomment-498021199
I think we can make it implicit in this case.
On Sun, Jun 2, 2019 at 3:51 AM Charith Ellawala <[email protected]>
wrote:
> *@charithe* commented on this pull request.
> ------------------------------
>
> In sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
> <https://github.com/apache/beam/pull/8725#discussion_r289636876>:
>
> > @@ -188,6 +191,15 @@
> .build();
> }
>
> + /** Read Beam {@link Row}s from a JDBC data source. */
> + @Experimental(Experimental.Kind.SCHEMAS)
> + public static ReadRows readRows() {
> + return new AutoValue_JdbcIO_ReadRows.Builder()
> + .setFetchSize(DEFAULT_FETCH_SIZE)
> + .setOutputParallelization(true)
> + .build();
> + }
>
> Do you prefer an explicit readWithSchema method or do you prefer it to be
> implicit?. That is:
>
> - Make the JDBC row mapper optional
> - If the user provides a JDBC row mapper, then:
> - If the output type of the row mapper exists in the registry,
> attach that schema to the output PCollection
> - Otherwise, the output PCollection will not have a schema
> - If the user does not provide a JDBC row mapper, then:
> - If the output type exists in the schema registry and is
> compatible with the inferred schema from the database, generate our
own row
> mapper to map the resultset and attach the schema to the output
PCollection
> - Otherwise, throw an exception
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/8725?email_source=notifications&email_token=AFAYJVIECRY3TJWPEAWLJTDPYOQ2BA5CNFSM4HRE7V22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2KJYYI#discussion_r289636876>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVKRJFTURD4UNFJIYLTPYOQ2BANCNFSM4HRE7V2Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 252834)
Time Spent: 1.5h (was: 1h 20m)
> The JdbcIO source should produce schemas
> ----------------------------------------
>
> Key: BEAM-6674
> URL: https://issues.apache.org/jira/browse/BEAM-6674
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-jdbc
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
