[
https://issues.apache.org/jira/browse/BEAM-6674?focusedWorklogId=256805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256805
]
ASF GitHub Bot logged work on BEAM-6674:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/19 11:03
Start Date: 10/Jun/19 11:03
Worklog Time Spent: 10m
Work Description: charithe commented on issue #8725: [BEAM-6674] Add
schema support to JdbcIO read
URL: https://github.com/apache/beam/pull/8725#issuecomment-500378106
I modified the code to attach the schema to PCollection if the type is
registered in the registry
(https://github.com/apache/beam/pull/8725/commits/046acd0c7f29e90beffb2fcf9a631f3a6bdc5da1).
Is that what you were expecting?
Regarding the `readRows` method I introduced which automatically generates a
row mapper based on the inferred schema, I am struggling to figure out a nice
way of exposing it without some duplication of the `Read` class.
- Reusing the `Read` class by making the row mapper and coder optional would
be confusing for users because they have to remember to explicitly create a
`Read<Row>` instance and be aware of the things they shouldn't set in that
instance.
- Extending the `Read` class won't work because the visibility of
`withRowMapper` and `withCoder` methods cannot be downgraded.
- As only row mapper and coder are optional, there are still quite few other
arguments that the user needs to pass. So making `readRows` accept them all in
the argument list would be unfriendly as well.
I may be over-thinking this part. Do you have a suggestion on how you would
design the API in this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 256805)
Time Spent: 2h 50m (was: 2h 40m)
> The JdbcIO source should produce schemas
> ----------------------------------------
>
> Key: BEAM-6674
> URL: https://issues.apache.org/jira/browse/BEAM-6674
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-jdbc
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
