[
https://issues.apache.org/jira/browse/BEAM-6674?focusedWorklogId=253094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253094
]
ASF GitHub Bot logged work on BEAM-6674:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/19 13:02
Start Date: 03/Jun/19 13:02
Worklog Time Spent: 10m
Work Description: charithe commented on pull request #8725: [BEAM-6674]
Add schema support to JdbcIO read
URL: https://github.com/apache/beam/pull/8725#discussion_r289832420
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -391,6 +403,123 @@ DataSource buildDatasource() {
void setParameters(PreparedStatement preparedStatement) throws Exception;
}
+ /** Implementation of {@link #readRows()}. */
+ @AutoValue
+ @Experimental(Experimental.Kind.SCHEMAS)
+ public abstract static class ReadRows extends PTransform<PBegin,
PCollection<Row>> {
Review comment:
Do you have any suggestions on how to do this? I wasn't happy with the
duplication either but I couldn't see a nice way to share state between
AutoValue classes. Both the existing `Read` and `ReadAll` classes are pretty
much identical to each other as well so I assumed that was a known issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 253094)
Time Spent: 2h (was: 1h 50m)
> The JdbcIO source should produce schemas
> ----------------------------------------
>
> Key: BEAM-6674
> URL: https://issues.apache.org/jira/browse/BEAM-6674
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-jdbc
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
