[
https://issues.apache.org/jira/browse/BEAM-6674?focusedWorklogId=255274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255274
]
ASF GitHub Bot logged work on BEAM-6674:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 17:33
Start Date: 06/Jun/19 17:33
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #8725: [BEAM-6674]
Add schema support to JdbcIO read
URL: https://github.com/apache/beam/pull/8725#discussion_r291293124
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -188,6 +191,15 @@
.build();
}
+ /** Read Beam {@link Row}s from a JDBC data source. */
+ @Experimental(Experimental.Kind.SCHEMAS)
+ public static ReadRows readRows() {
+ return new AutoValue_JdbcIO_ReadRows.Builder()
+ .setFetchSize(DEFAULT_FETCH_SIZE)
+ .setOutputParallelization(true)
+ .build();
+ }
Review comment:
I was thinking that this would allow us to not have to create a separate
fork of the Read PTransform. Just keep one Read<T>, which happens to support
schemas (as long as T is in the SchemaRegistry); yes the user can call
setSchema themselves, however forcing the user to do a lookup in the
SchemaRegistry themselves in ugly, and we should make that implicit. Then
readRows will just return Read<Row>, so we should not need a separate class.
Does that work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255274)
Time Spent: 2h 20m (was: 2h 10m)
> The JdbcIO source should produce schemas
> ----------------------------------------
>
> Key: BEAM-6674
> URL: https://issues.apache.org/jira/browse/BEAM-6674
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-jdbc
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
