sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata
service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170902428
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -142,6 +145,9 @@
// Features
final Feature disableEnsembleChangeFeature;
+ final MetadataClientDriver metadataDriver;
+ // Registration client to discover bookies
+ final RegistrationClient regClient;
Review comment:
@ivankelly MetadataClientDriver is not replacing RegClient. it is just
changing how regclient was built here. I will have subsequent changes to clean
up after removing `getZkHandle`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
