sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata
service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170902906
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java
##########
@@ -133,13 +122,15 @@ public void safeRun() {
@Override
public void accept(Versioned<Set<BookieSocketAddress>> bookieSet,
Throwable throwable) {
if (throwable != null) {
- scheduleWatchTask(ZK_CONNECT_BACKOFF_MS);
- firstRunFuture.completeExceptionally(throwable);
+ if (firstRunFuture.isDone()) {
Review comment:
yes that is aligned to the method signature, I don't change the original
design here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
