sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata
service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170902665
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -525,9 +532,9 @@ public BookKeeper(ClientConfiguration conf, ZooKeeper zk,
EventLoopGroup eventLo
// initialize ledger manager
try {
this.ledgerManagerFactory =
- AbstractZkLedgerManagerFactory.newLedgerManagerFactory(conf,
regClient.getLayoutManager());
- } catch (IOException | InterruptedException e) {
- throw e;
+ this.metadataDriver.getLedgerManagerFactory();
Review comment:
there is a subsequent change on ledger manager factory. would defer changing
that to ledger manager factory change, not sure it worth being stuck at here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
