sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179289148
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -83,18 +88,18 @@
*/
public class EntryLogger {
private static final Logger LOG =
LoggerFactory.getLogger(EntryLogger.class);
+ private static final Long INVALID_LEDGERID = Long.valueOf(-1);
Review comment:
use a special negative value instead of `-1`. also I don't think it is
`INVALID_LEDGERID`, it is actually "UNASSIGNED". because it is used in
`BufferedLogChannel` when a buffered channel is not specifically assigned to a
ledger in single entry log manager.
also use long instead of `Long` to avoid boxing/unboxing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
