sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179293507
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -393,12 +513,37 @@ public BufferedReadChannel getFromChannels(long logId) {
*
* @return least unflushed log id.
*/
- synchronized long getLeastUnflushedLogId() {
- return leastUnflushedLogId;
+ long getLeastUnflushedLogId() {
+ return recentlyCreatedEntryLogsStatus.getLeastUnflushedLogId();
}
- synchronized long getCurrentLogId() {
- return logChannel.getLogId();
+ long getPreviousAllocatedEntryLogId() {
+ return entryLoggerAllocator.getPreallocatedLogId();
+ }
+
+ boolean rollLogsIfEntryLogLimitReached() throws IOException {
Review comment:
why not make `rollLogsIfEntryLogLimitReached` as part of `EntryLogManager`?
so simple entry log manager is much simpler. you can do these heavy lifting
management in per ledger entry log implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
