sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179290558
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -83,18 +88,18 @@
*/
public class EntryLogger {
private static final Logger LOG =
LoggerFactory.getLogger(EntryLogger.class);
+ private static final Long INVALID_LEDGERID = Long.valueOf(-1);
+ // log file suffix
+ private static final String LOG_FILE_SUFFIX = ".log";
static class BufferedLogChannel extends BufferedChannel {
private final long logId;
private final EntryLogMetadata entryLogMetadata;
private final File logFile;
+ private Long ledgerId = INVALID_LEDGERID;
Review comment:
I'd prefer naming it to something meaningful, like 'ledgerIdAssigned',
meaning it is a entry log file that assigned to a specific ledger.
make it final if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
