sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179294437
Advertising
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyEntryLogger.java
##########
@@ -54,7 +49,7 @@ protected boolean removeEntryLog(long entryLogId) {
}
@Override
- public synchronized long addEntry(long ledger, ByteBuffer entry) throws
IOException {
+ public synchronized long addEntry(Long ledgerId, ByteBuffer entry) throws
IOException {
Review comment:
I see you changed "long" to "Long" in a lot of places. what is the
consideration behind this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
