[
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168785#comment-16168785
]
Julian Hyde commented on CALCITE-1913:
--------------------------------------
[~christian.beikov], Reviewing
https://github.com/apache/calcite/pull/540/commits/e382cabf69cd6171266413a7b25d544522c979b8.
A few comments:
* SqlDialect used to have few dependencies (and this was kind of a goal when I
wrote the class), now it has more. Any chance we can reduce the coupling? I.e.
remove dependencies on things like SqlImplementor, RelDataType, SqlNode.
* Thanks for retaining DatabaseProduct in the short term.
* The things that were annotated Experimental don't need to be marked
Deprecated; we can just kill them with no notice.
* Let's remove the DatabaseMetaData constructor parameter from SqlDialect.
DatabaseMetaData contains a Connection, and we don't want the slightest chance
that a Dialect will keep that Connection and prevent it from being
garbage-collected. Get everything you need from DatabaseMetaData in the
factory, before you call the constructor.
* Before we commit to master, we will need to remove all uses of deprecated
APIs (we can mask a few with @SuppressWarnings("deprecation"))
* Use AvaticaUtils.instantiatePlugin rather than Class.forName. It has a bit
more functionality.
This is a big improvement, and I think we can get this committed pretty soon.
[~chris-baynes], Hope you're ok with Handler being removed. I think that now we
have a dialect factory, there are better ways to achieve the same thing. Let me
know what you think.
> Include DB version in SqlDialect
> --------------------------------
>
> Key: CALCITE-1913
> URL: https://issues.apache.org/jira/browse/CALCITE-1913
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.13.0
> Reporter: Jess Balint
> Assignee: Jess Balint
> Priority: Minor
>
> It would be useful to have the DB version # in the SqlDialect for unparsing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
