[
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167427#comment-16167427
]
Abbas Gadhia commented on CALCITE-1913:
---------------------------------------
I think the names of the classes of the dialects are indicative enough that a
particular dialect behaves like a particular product. For example: the class
*PostgresqlSqlDialect* is sufficient to say that it "behaves like Postgres".
With this, I think there may not be a need of a special DatabaseProduct enum. I
was initially inclined to keep the DatabaseProduct enum, but in retrospect, not
anymore.
If there are multiple dialects that behave like Postgres, then i'm assuming
that they will be a part of the same dialect class hierarchy and hence if
really must, I could do something like *if(dialect instanceof
PostgresqlSqlDialect)* to figure out if the dialect I have with me has a parent
class of PostgresqlSqlDialect. I'm ofc assuming that we are ok having multiple
dialects such as Postgresql84SqlDialect and Postgresql96SqlDialect along with
the base PostgresqlSqlDialect
> Include DB version in SqlDialect
> --------------------------------
>
> Key: CALCITE-1913
> URL: https://issues.apache.org/jira/browse/CALCITE-1913
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.13.0
> Reporter: Jess Balint
> Assignee: Jess Balint
> Priority: Minor
>
> It would be useful to have the DB version # in the SqlDialect for unparsing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
