[
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167563#comment-16167563
]
Christian Beikov commented on CALCITE-1913:
-------------------------------------------
Here is the PR for this work: https://github.com/apache/calcite/pull/540
I wouldn't necessarily create various subtypes for the same product line but
have a single one that "self-configures" based on the metadata. Apart from
that, I wouldn't rely on instanceof checks because of all the reasons I
mentioned so far. Enabling features based on a class hierarchy is just like
doing it based on enum value, which IMO is simply not a good idea. If users
don't want a specific feature or do want a specific feature that requires the
dialect to be a subclass of a specific class they might not be able to achieve
that properly when having "conflicting" requirements i.e. having to extend two
classes.
> Include DB version in SqlDialect
> --------------------------------
>
> Key: CALCITE-1913
> URL: https://issues.apache.org/jira/browse/CALCITE-1913
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.13.0
> Reporter: Jess Balint
> Assignee: Jess Balint
> Priority: Minor
>
> It would be useful to have the DB version # in the SqlDialect for unparsing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
