[
https://issues.apache.org/jira/browse/CALCITE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596568#comment-16596568
]
Josh Elser commented on CALCITE-2385:
-------------------------------------
bq. exclude the dockerfile from being checked for modifications is acceptable
No, I think that's the wrong solution.
You're ultimately calling {{mvn deploy -Papache-release}} on a SNAPSHOT
version, [~francischuang]? I could see this causing you problem. I would just
add an option to the pom to let you provide another option (e.g.
{{-DskipDockerCheck}}) that you can also provide when you do the dry-run.
> Cannot build if we update the AVATICA_VERSION in the dockerfile during a
> dry-run release
> ----------------------------------------------------------------------------------------
>
> Key: CALCITE-2385
> URL: https://issues.apache.org/jira/browse/CALCITE-2385
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Francis Chuang
> Assignee: Francis Chuang
> Priority: Major
>
> This happens when building a dry-run release per the instructions here:
> [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
> If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there
> being modified files in the working tree.
> If we do not patch the docker file, maven fails because it expects
> AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
> A solution would be to exclude the docker file from being checked for
> modifications in pom.xml. Is this a reasonable approach?
>
> CC [~elserj]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
