[
https://issues.apache.org/jira/browse/CALCITE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596904#comment-16596904
]
Francis Chuang commented on CALCITE-2385:
-----------------------------------------
[~elserj], Yes, I am trying to execute `release:deploy` on SNAPSHOT/master.
Following the directions here:
[https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
These bits in particular:
{code:java}
# Make sure that there are no junk files in the sandbox
git clean -xn
# For the dry run, edit the docker/dockerhub/Dockerfile
patch -p1 <<EOF
diff --git a/docker/src/main/dockerhub/Dockerfile
b/docker/src/main/dockerhub/Dockerfile
index 4617a4e..4ccd97f 100644
--- a/docker/src/main/dockerhub/Dockerfile
+++ b/docker/src/main/dockerhub/Dockerfile
@@ -23,3 +23,3 @@ RUN mkdir -p /home/avatica/classpath
# This line must be preserved. The Maven build will verify this version matches
its version
-ARG AVATICA_VERSION="1.12.0"
+ARG AVATICA_VERSION="1.12.0-SNAPSHOT"
EOF
# Do a dry run of the release:prepare step, which sets version numbers.
# Typically we increment minor version: If X.Y.Z is 1.11.0, X2.Y2.Z2 is 1.12.0.
mvn -DdryRun=true -DreleaseVersion=X.Y.Z -DdevelopmentVersion=X2.Y2.Z2-SNAPSHOT
-Dtag=avatica-X.Y.Z-rcN -Papache-release -Duser.name=${asf.username}
release:prepare
{code}
I don't have the bandwidth to dive into the maven docs at the moment. Do you
mind taking this over and committing a fix?
I do have a script for automating the build in a docker container that I would
like to commit, but I'd like to have the fix for this committed first as the
script I am building should follow the manual release instructions faithfully.
> Cannot build if we update the AVATICA_VERSION in the dockerfile during a
> dry-run release
> ----------------------------------------------------------------------------------------
>
> Key: CALCITE-2385
> URL: https://issues.apache.org/jira/browse/CALCITE-2385
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Francis Chuang
> Assignee: Francis Chuang
> Priority: Major
>
> This happens when building a dry-run release per the instructions here:
> [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
> If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there
> being modified files in the working tree.
> If we do not patch the docker file, maven fails because it expects
> AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
> A solution would be to exclude the docker file from being checked for
> modifications in pom.xml. Is this a reasonable approach?
>
> CC [~elserj]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
