[
https://issues.apache.org/jira/browse/CALCITE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686185#comment-16686185
]
Francis Chuang commented on CALCITE-2385:
-----------------------------------------
I have pushed a commit implementing an profile activation property to implement
this:
[https://github.com/F21/calcite-avatica/commit/f942ceed68ea74b494591e0b8eef6582f93b7d5d]
According to maven's documentation, prepending a property with ! will cause the
profile to be activated only if the property does not exist:
[https://maven.apache.org/guides/introduction/introduction-to-profiles.html]
Unfortunately, I am not able to get it to work in the last 2 days.
When I execute `mvn -DdryRun=true -DreleaseVersion=1.13.0
-DdevelopmentVersion=1.14.0-SNAPSHOT -Dtag="avatica-1.13.0-rc0"
-Papache-release -Duser.name=francischuang -DskipDockerCheck release:prepare`,
the docker check profile is still activated and still fails.
> Cannot build if we update the AVATICA_VERSION in the dockerfile during a
> dry-run release
> ----------------------------------------------------------------------------------------
>
> Key: CALCITE-2385
> URL: https://issues.apache.org/jira/browse/CALCITE-2385
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Francis Chuang
> Assignee: Francis Chuang
> Priority: Major
>
> This happens when building a dry-run release per the instructions here:
> [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
> If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there
> being modified files in the working tree.
> If we do not patch the docker file, maven fails because it expects
> AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
> A solution would be to exclude the docker file from being checked for
> modifications in pom.xml. Is this a reasonable approach?
>
> CC [~elserj]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
