[ https://issues.apache.org/jira/browse/CALCITE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696284#comment-16696284 ]
ASF GitHub Bot commented on CALCITE-2385: ----------------------------------------- GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica/pull/79 [CALCITE-2385] Use Docker Hub hooks to select Avatica version during image build and publish HSQLDB image cc @joshelser You can merge this pull request into a Git repository by running: $ git pull https://github.com/F21/calcite-avatica docker-hub-hooks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/calcite-avatica/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 ---- commit a5716fc6923af49dfe6167fbde11b394336bfe47 Author: Francis Chuang <francischuang@...> Date: 2018-11-22T22:37:05Z [CALCITE-2385] Use Docker Hub hooks to select Avatica version during image build and publish HSQLDB image ---- > Cannot build if we update the AVATICA_VERSION in the dockerfile during a > dry-run release > ---------------------------------------------------------------------------------------- > > Key: CALCITE-2385 > URL: https://issues.apache.org/jira/browse/CALCITE-2385 > Project: Calcite > Issue Type: Bug > Components: avatica > Reporter: Francis Chuang > Assignee: Francis Chuang > Priority: Major > Fix For: avatica-1.13.0 > > > This happens when building a dry-run release per the instructions here: > [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers] > If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there > being modified files in the working tree. > If we do not patch the docker file, maven fails because it expects > AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION. > A solution would be to exclude the docker file from being checked for > modifications in pom.xml. Is this a reasonable approach? > > CC [~elserj] -- This message was sent by Atlassian JIRA (v7.6.3#76005)