[
https://issues.apache.org/jira/browse/CALCITE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687756#comment-16687756
]
ASF GitHub Bot commented on CALCITE-2385:
-----------------------------------------
GitHub user F21 opened a pull request:
https://github.com/apache/calcite-avatica/pull/78
[CALCITE-2385] Add flag to disable dockerfile checks when executing a
dry-run build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/F21/calcite-avatica
fix-dry-run-dockerfile-verfication-failure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 3f0e5afe2d6b05178686ea0454f57c9de4883655
Author: Francis Chuang <francischuang@...>
Date: 2018-11-12T22:52:35Z
[CALCITE-2385] Add flag to disable dockerfile checks when executing a
dry-run build
----
> Cannot build if we update the AVATICA_VERSION in the dockerfile during a
> dry-run release
> ----------------------------------------------------------------------------------------
>
> Key: CALCITE-2385
> URL: https://issues.apache.org/jira/browse/CALCITE-2385
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Francis Chuang
> Assignee: Francis Chuang
> Priority: Major
>
> This happens when building a dry-run release per the instructions here:
> [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
> If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there
> being modified files in the working tree.
> If we do not patch the docker file, maven fails because it expects
> AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
> A solution would be to exclude the docker file from being checked for
> modifications in pom.xml. Is this a reasonable approach?
>
> CC [~elserj]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
