Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188882558
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java
---
@@ -89,15 +89,19 @@ public
IncrementalColumnDictionaryGenerator(CarbonDimension dimension, int maxVa
}
@Override public Integer getKey(String value) {
- return incrementalCache.get(value);
+ synchronized (lock) {
--- End diff --
This lock is not required
---
