Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188969041
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalType.java
---
@@ -44,4 +44,35 @@ public int getScale() {
public void setScale(int scale) {
this.scale = scale;
}
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj) {
+ return true;
+ }
+ if (obj == null) {
+ return false;
+ }
+ if (!(obj instanceof DecimalType)) {
+ return false;
+ }
+ if (!this.getName().equalsIgnoreCase(((DecimalType) obj).getName())) {
+ return false;
+ }
+ if (this.precision != ((DecimalType) obj).precision) {
+ return false;
+ }
+ if (this.scale != ((DecimalType) obj).scale) {
+ return false;
+ }
+ return true;
+ }
+
+ @Override
+ public int hashCode() {
+ final int prime = 31;
+ int result = 1;
+ result = prime * result + getName().hashCode();
--- End diff --
should include precision.hash and scala.hash
---
