Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2313#discussion_r188965798
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/datatype/ArrayType.java 
---
    @@ -31,6 +31,31 @@ public boolean isComplexType() {
         return true;
       }
     
    +  @Override
    +  public boolean equals(Object obj) {
    +    if (this == obj) {
    +      return true;
    +    }
    +    if (obj == null) {
    +      return false;
    +    }
    +    if (!(obj instanceof ArrayType)) {
    +      return false;
    +    }
    +    if (!this.getName().equalsIgnoreCase(((ArrayType) obj).getName())) {
    --- End diff --
    
    Equals and hash should be implemented for all datatypes.Each required to 
have different logic
    1) Nestedtype, should also include childType.equals.
    2) Decimal type should consider precision, scala  etc.


---

Reply via email to